FI-3732: Add scratch to runnable context #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #614 +/- ##
=======================================
Coverage 84.70% 84.70%
=======================================
Files 283 283
Lines 12397 12397
Branches 1503 1503
=======================================
Hits 10501 10501
Misses 1888 1888
Partials 8 8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Shaumik-Ashraf
approved these changes
Feb 13, 2025
vanessuniq
approved these changes
Feb 13, 2025
Jammjammjamm
force-pushed
the
fi-3732-add-scratch-to-runnable-context
branch
from
3eb229e to
d560d0a
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This branch adds the ability to pass
scratchto therunmethod in the runnable context.Testing Guidance
[This g10 branch] was updated to use this functionality, and its unit tests should pass if you point
inferno_coreit at this branch in its Gemfile, but will fail if you point it at the main branch ofinferno_core. In that g10 branch's last commit, you can see that arunmethod which includedscratchwas removed.